Mercurial > hg > index.cgi
view lwar/lwar.h @ 434:052c5f335a92
Fix bug in like terms collection in expression simplification
Like term collection would lose the actual "variable" part of the term if
the second term collected happened to have no coefficient. This would cause
the expression to take the value of the calculated coefficient which is
obviously wrong.
Thanks to hider <stego@satx.rr.com> for reporting the bug and providing a
proper test case.
Observation: this bug has been present since the first pre-release of
lwtools 3.0 when the algebraic expression system was introduced. Apparently
people tend not to create expressions that trigger the like terms handler.
The specific conditions require the symbol to be undefined and the second
operand to the addition has to have no coefficient so it's likely a fairly
rare scenario. Still, it is somewhat surprising that nobody tripped on it
before now.
author | William Astle <lost@l-w.ca> |
---|---|
date | Mon, 23 Jan 2017 22:58:36 -0700 |
parents | 45df37e81741 |
children |
line wrap: on
line source
/* lwar.h Copyright © 2009 William Astle This file is part of LWAR. LWAR is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version. This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with this program. If not, see <http://www.gnu.org/licenses/>. Contains the main defs used by the linker */ #define LWAR_OP_LIST 1 #define LWAR_OP_ADD 2 #define LWAR_OP_REMOVE 3 #define LWAR_OP_CREATE 4 #define LWAR_OP_EXTRACT 5 #define LWAR_OP_REPLACE 6 #ifndef __lwar_h_seen__ #define __lwar_h_seen__ #ifndef __lwar_c_seen__ extern char *archive_file; extern int debug_level; extern int operation; extern int nfiles; extern char **files; extern int mergeflag; extern int filename_flag; //typedef void * ARHANDLE; #define AR_MODE_RD 1 #define AR_MODE_WR 2 #define AR_MODE_RW 3 #define AR_MODE_CREATE 4 #define __lwar_E__ extern #else #define __lwar_E__ #endif // __lwar_c_seen__ __lwar_E__ void add_file_name(char *fn); __lwar_E__ char *get_file_name(char *fn); //__lwar_E__ ARHANDLE open_archive(char *fn, int mode); #undef __lwar_E__ #endif //__lwar_h_seen__