Mercurial > hg > index.cgi
view docs/internals.txt @ 434:052c5f335a92
Fix bug in like terms collection in expression simplification
Like term collection would lose the actual "variable" part of the term if
the second term collected happened to have no coefficient. This would cause
the expression to take the value of the calculated coefficient which is
obviously wrong.
Thanks to hider <stego@satx.rr.com> for reporting the bug and providing a
proper test case.
Observation: this bug has been present since the first pre-release of
lwtools 3.0 when the algebraic expression system was introduced. Apparently
people tend not to create expressions that trigger the like terms handler.
The specific conditions require the symbol to be undefined and the second
operand to the addition has to have no coefficient so it's likely a fairly
rare scenario. Still, it is somewhat surprising that nobody tripped on it
before now.
author | William Astle <lost@l-w.ca> |
---|---|
date | Mon, 23 Jan 2017 22:58:36 -0700 |
parents | 2c24602be78f |
children |
line wrap: on
line source
LWASM Internals =============== LWASM is a table-driven assembler that notionally uses two passes. However, it implements its assembly in several passes as follows. Pass 1 ------ This pass reads the entire source code and parses each line into an internal representation. Macros, file inclusions, and conditional assembly instructions are resolved at this point as well. Instructions with known sizes will have their sizes resolved at this point. Pass 2 ------ Check all exported symbols for validity and set them as imports if the assembler state says so. Also resolve all symbol references in all expressions to be direct references either to the symbol table or to the import list. Pass 3 ------ This pass resolves all instruction sizes that can be resolved without forcing any instruction sizes. This pass will run repeatedly until no no new resolution occurs. Pass 4 ------ Work through all un-resolved instructions and force sizes. After each size is forced, try re-resolving all other instructions. This is done starting at the beginning of the source and working forward. If any instruction does not resolve when forced, an error will be thrown. Pass 5 ------ Constantize all line addresses and throw errors if any cannot be. This pass will repeat until no further lines addresses are reduced to constants at which time all lines will be checked for constant-ness. Pass 6 ------ Finalize all expressions related to instructions. Carp about any that cannot be reduced to a usable form. That means, for the non-object target all expressions must resolve to a constant. For the object form, all expressions must resolve to symbol references and constants. Those symbol references may be internal or external. Pass 7 ------ Emit object code for each line for later output.